Pid unconstrained itemp #4914
Merged
Pid unconstrained itemp #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
RCBugFix
branch
2 times, most recently
from
b97e3d4 to
0d9efb2
Compare
|
@Rerouter I submitted a PR to your branch, applying the config changes more widely. Once that's merged, this can be merged too! |
Apply changes to all configs
|
Merged them in, ready when you are. |
|
👽 fingers crossed it unleashes heating and solves all our PID woes. Is any similar change needed for |
|
In reality it resolves a corner case from (very) very rapid extrusion that the heater cannot hope to keep up with the demand, (integral saturation where derivative is close to 0) Give me tomorrow to recheck myself and i'll make a pull request for removing the pid functional range limitation, from another issue log i can see other devs may take issue with it, but i'll make it and let you guys decide the route you wish to take, |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cleanup as requested for the PID issue, It unconstrains the Iterm, and removes all variables relating to the constraint
Addressing #4881.