Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken MBL #5634

Closed
wants to merge 3 commits into from
Closed

Fix for broken MBL #5634

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 30, 2016

LCD call was waiting forever, causing the system to hang.

LCD call was waiting forever, causing the system to hang.
@@ -1298,10 +1298,10 @@ void kill_screen(const char* lcd_msg) {
#endif
;
if (no_reentrance) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are no longer setting no_reentrance with lcd_wait_for_homing, I would remove this line.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ghost
Copy link
Author

ghost commented Jan 5, 2017

Can we ditch the whole lcd_wait_for_homing() function? I cannot find any other calls to it.

autonumous pushed a commit to autonumous/MarlinFirmware-BigBoxV1.1 that referenced this pull request Jan 9, 2017
@thinkyhead
Copy link
Member

Can we ditch the whole lcd_wait_for_homing() function?

No. It's okay that it's only used once, currently. And I think the proper fix is actually this:

  inline void lcd_wait_for_homing() {
    no_reentrance = true;
    while (!axis_homed[X_AXIS] || !axis_homed[Y_AXIS] || !axis_homed[Z_AXIS]) idle();
-   no_reentrance = true;
+   no_reentrance = false;
  }

@thinkyhead
Copy link
Member

Should be fixed now, with fb3c30e, as above. Please confirm.

@ghost
Copy link
Author

ghost commented Jan 12, 2017

First off, welcome back, @thinkyhead!

I can try it this evening.

@thinkyhead
Copy link
Member

Good to be back. I hope to be around a bit more. Still much to do in this move to Texas….

@ghost
Copy link
Author

ghost commented Jan 14, 2017

That commit didn't work. Details are on your commit.

@WheresWaldo
Copy link

Is there any movement on this PR. I had a bunch of reports from the Robo3D users that have migrated to 1.1.0 RCBugFix that are reporting MESH freezing during implementation. All with code from December 31, 2016.

I was trying to maintain configuration files for the Robo R1 printer and everyone now has gone back to RC8 since the anomalous behavior is not present.

@manianac
Copy link
Contributor

Awaiting @thinkyhead s return, until then you'll have to experiment with your own PR or code regression.

@Sparkman61
Copy link

For what its worth, the change posted by @thinkyhead seemed to correct the freezing problem. At least on my printer.

@WheresWaldo
Copy link

I did not know Scott was away. I will wait for his return.

@thinkyhead
Copy link
Member

I've made the move to Austin, but my 3D printers are still in the mail. Once they arrive (in 2-3 days) I will be able to troubleshoot more. This PR won't be the solution, so I'm closing it.

@thinkyhead thinkyhead closed this Feb 6, 2017
@thinkyhead thinkyhead reopened this Feb 15, 2017
@thinkyhead thinkyhead closed this Feb 15, 2017
@ghost ghost deleted the RCBugFix---MBL-fix branch April 1, 2017 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants