-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for broken MBL #5634
Fix for broken MBL #5634
Conversation
LCD call was waiting forever, causing the system to hang.
@@ -1298,10 +1298,10 @@ void kill_screen(const char* lcd_msg) { | |||
#endif | |||
; | |||
if (no_reentrance) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are no longer setting no_reentrance
with lcd_wait_for_homing
, I would remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Can we ditch the whole |
No. It's okay that it's only used once, currently. And I think the proper fix is actually this: inline void lcd_wait_for_homing() {
no_reentrance = true;
while (!axis_homed[X_AXIS] || !axis_homed[Y_AXIS] || !axis_homed[Z_AXIS]) idle();
- no_reentrance = true;
+ no_reentrance = false;
} |
Should be fixed now, with fb3c30e, as above. Please confirm. |
First off, welcome back, @thinkyhead! I can try it this evening. |
Good to be back. I hope to be around a bit more. Still much to do in this move to Texas…. |
That commit didn't work. Details are on your commit. |
Is there any movement on this PR. I had a bunch of reports from the Robo3D users that have migrated to 1.1.0 RCBugFix that are reporting MESH freezing during implementation. All with code from December 31, 2016. I was trying to maintain configuration files for the Robo R1 printer and everyone now has gone back to RC8 since the anomalous behavior is not present. |
Awaiting @thinkyhead s return, until then you'll have to experiment with your own PR or code regression. |
For what its worth, the change posted by @thinkyhead seemed to correct the freezing problem. At least on my printer. |
I did not know Scott was away. I will wait for his return. |
I've made the move to Austin, but my 3D printers are still in the mail. Once they arrive (in 2-3 days) I will be able to troubleshoot more. This PR won't be the solution, so I'm closing it. |
LCD call was waiting forever, causing the system to hang.