G33 minor change #6558
Closed
G33 minor change #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LVD-AC
commented
May 3, 2017
LVD-AC
commented
- further named remaining tests
- A and O parameters obsolete
- quick homing with home_delta()
- use home_delta() instead of home_all_axis - further naming tests - getting rid of O and A parameters: always quick P1 - one T parameter: changed to bool -> T1 (default when ommited) tower angles on, T0 tower angles off
LVD-AC
commented
May 3, 2017
Marlin/Marlin_main.cpp
Outdated
|
|
||
| home_all_axes(); | ||
| #if HOTENDS > 1 | ||
| const uint8_t old_tool_index = active_extruder; |
There was a problem hiding this comment.
this line is obsolete
There was a problem hiding this comment.
You have my leave to remove it.
thinkyhead
reviewed
May 4, 2017
Marlin/Marlin_main.cpp
Outdated
| #if HAS_LEVELING | ||
| set_bed_leveling_enabled(false); | ||
| reset_bed_level; //after calibration bed-level will no longer be valid |
There was a problem hiding this comment.
What about reset_bed_level? To call it, add parentheses ().
There was a problem hiding this comment.
ok, i'll do so tomorrow
thinkyhead
reviewed
May 4, 2017
Marlin/Marlin_main.cpp
Outdated
| @@ -5412,11 +5411,14 @@ void home_all_axes() { gcode_G28(); } | |||
| } | |||
|
|
|||
| stepper.synchronize(); | |||
|
|
|||
| home_all_axes(); | |||
| endstops.enable(true); | |||
There was a problem hiding this comment.
setup_for_endstop_or_probe_move perhaps here? And after homing, clean_up_after_endstop_or_probe_move… possibly… See if these functions do the right thing for this situation.
There was a problem hiding this comment.
In general, after enabling endstops to do something, when done the method to call is endstops.not_homing() which will set them back to their global non-homing state.
…ERIAL_PROTOCOL_F (MarlinFirmware#6584) also removed wayward 'address of' ampersand in setTargetHotend and setTargetBed parameters
Fixed USE_CONTROLLER_FAN #define usage
…x' into LVD_delta_autocal
…x' into LVD_delta_autocal
…ixes Update git helper scripts, config comments
…x' into LVD_delta_autocal
|
Squashed and cleaned in #6621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.