Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force legacy "pristine" build dist for TravisCI #7421

Conversation

fiveangle
Copy link
Contributor

TravisCI "trusty" build dist isn't picking up build path causing travis checks to fail. Reverting to legacy "pristine" dist while we investigate

TravisCI "trusty" build dist isn't picking up build path causing travis checks to fail.  Reverting to legacy "pristine" dist while we investigate
@Bob-the-Kuhn Bob-the-Kuhn merged commit 118b616 into MarlinFirmware:bugfix-2.0.x Aug 3, 2017
@fiveangle
Copy link
Contributor Author

fiveangle commented Aug 3, 2017

i made a mistake bob will fix in a second

pristine != precise

travis will build on whatever platform is available (trusty or precise) so we have to check the raw log of any "passing" build to ensure it ran on the right environment, which this commit didn't

with fix shortly so you can push

@fiveangle
Copy link
Contributor Author

Okay, #7424 is ready - thanks Bob !

@Roxy-3D
Copy link
Member

Roxy-3D commented Aug 3, 2017

OK... The next time a person submits a Pull Request... We can verify that Travis is doing the right thing!!!!

@fiveangle
Copy link
Contributor Author

it took me longer than expected, but i did find out why it wasn't building on trusty

shall i push yet another travis fix that forces trusty with the required settings ? i don't know now much longer precise will stick around.

@Roxy-3D
Copy link
Member

Roxy-3D commented Aug 3, 2017

Probably that makes sense.... But here is a question: Travis takes so long to generate results. If we can be on the server that hardly anybody is using, our Travis checks will go faster, right? Does it make sense to wait to switch until the server goes away?

@fiveangle
Copy link
Contributor Author

fiveangle commented Aug 3, 2017

i tested and it built in 5:12 on trusty, 5:35 on precise, so i don't think it gets us much

wait until everything is on platformio: python is about twice as slow to do the build, but i have some ideas how we can fix that: travis supports parallelization for builds, so as long as we don't get a nasty letter from Travis CI GmbH, I'm thinking one thread for the avr, one for the 32bit, and another to run through everything in example_configurations (automatically) and hopefully still be close to the 5min mark. baby steps...

For precise and trusty with sudo enabled, full virtualization is required, so i'm sure they both run on the same cloud of hypervisors. It's the new trusty containerized build environment (the default) that will offer improved speed, but that's not an option for current marlin travis build.

@Roxy-3D
Copy link
Member

Roxy-3D commented Aug 3, 2017

OK! Its your call on what the right path is. If we should be using Trusty... And we know how to do that....

@p3p
Copy link
Member

p3p commented Aug 3, 2017

The bugfix-2.0.x Travis script runs tests on AVR and Teensy 32-bit, nothing is built in python its just a wrapper for the same compiler and with the automated build platform install and caching I actually see performance improvements over the old Travis scripts?

@Roxy-3D
Copy link
Member

Roxy-3D commented Aug 3, 2017

When the Travis check complete... I'll hit the merge button on #7425

Thank You @fiveangle !!!!

@fiveangle
Copy link
Contributor Author

fiveangle commented Aug 3, 2017

@p3p - PIO is written in python and it's slow as molassis compared to the avr build chain (at least on my box compiling for PRINTRBOARD_REVF, but perhaps python on OS X is just slow ???)

current build on bf2 using pio sits at 12 min, bf1 using avr sits at 5 min. it's not a perfect comparison because there's more being built on bf2, but the need to parallelize travis is obvious :)

@p3p
Copy link
Member

p3p commented Aug 3, 2017

Any platform that can run all default tests can just have another ENV defined and it will run in parallel, bugfix-2.0.x ran both AVR and Teensy tests in 7 mins on my last Travis run, It all depends on what resources Travis allocates you.

@p3p
Copy link
Member

p3p commented Aug 3, 2017

We cant do this yet, because the default script currently has the Teensy tests in as well, but its something to work towards ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants