Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add M997 Restart Page #244

Merged
merged 5 commits into from
Oct 11, 2019

Conversation

reloxx13
Copy link
Contributor

@reloxx13 reloxx13 commented Sep 9, 2019

@reloxx13
Copy link
Contributor Author

reloxx13 commented Sep 9, 2019

Unsure about flag since: 2.0.0 ?

@reloxx13 reloxx13 changed the title Add M997 Restart Page [DOC] Add M997 Restart Page Sep 9, 2019
@p3p
Copy link
Member

p3p commented Sep 9, 2019

M997 only restarts because the LPC176x (and now some STMF1) only require restarted to flash the firmware.bin file already copied to the sd card, the command is actually Perform in-application firmware update as stated in the rep-rap gcode list.

For some future implementations this command could do much more than just restarting.

@shitcreek
Copy link
Contributor

LMK when this is ready to be merged

@shitcreek
Copy link
Contributor

@reloxx13 is this ready to be merged now?

@reloxx13
Copy link
Contributor Author

reloxx13 commented Oct 7, 2019

heya,
from my side, yes. i dunno if @p3p wanted (or want me) to add sth.

@p3p
Copy link
Member

p3p commented Oct 7, 2019

I was trying to explain that M997 isn't a Restart command ^^ that's just what it does on platforms where restarting triggers a firmware flash. So the naming is a bit off.

Using it as a restart command could be mentioned though, I just don't wan't Marlins documentation to conflict with the 'official' reprap gcode list.

@reloxx13
Copy link
Contributor Author

reloxx13 commented Oct 8, 2019

I was trying to explain that M997 isn't a Restart command ^^ that's just what it does on platforms where restarting triggers a firmware flash. So the naming is a bit off.

it executes eg.
NVIC_SystemReset(); or nvic_sys_reset();

Updating firmware is "a bonus" since some boards will always update after a restart if there is a firmware file on sd and only if it is supported by the bootloader.
There may boards which does not flash on boot but still could support M997 restart.

That was the reason i called it "Restart".

@p3p
Copy link
Member

p3p commented Oct 8, 2019

Updating firmware is "a bonus" since some boards will always update after a restart if there is a firmware file on sd and only if it is supported by the bootloader.

No that's the wrong way round, as the reprap standard states M997 flashes the firmware, it's the restart that is just a function of performing that action.

I realise that the implementation I added does just restart, but again that is only because it is necessary to perform the firmware flash on those platforms.

In my opinion the Marlin documentation should state that M997 performs a firmware update, mentioning that on some platforms (LPC176x), or specific boards in the STM32 case, this is done by performing a restart and letting the bootloader take care of it.

@reloxx13
Copy link
Contributor Author

reloxx13 commented Oct 10, 2019

@p3p pls review :)

grafik

@p3p
Copy link
Member

p3p commented Oct 10, 2019

looks good, although LPC176x is a platform not a board and STM32 covers 3 separate platforms, .. I'm not sure how many STM32 boards actually support this.

@shitcreek
Copy link
Contributor

I think it's good enough. LMK if there needs to be any correction.

@shitcreek shitcreek merged commit 3c4b057 into MarlinFirmware:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants