Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add M306 documentation #442

Merged
merged 9 commits into from
Jun 4, 2022
Merged

Add M306 documentation #442

merged 9 commits into from
Jun 4, 2022

Conversation

CRCinAU
Copy link
Contributor

@CRCinAU CRCinAU commented Apr 1, 2022 •
edited
Loading

Adds basic M306 documentation for PR MarlinFirmware/Marlin#23751

@tombrazier
Copy link
Contributor

Thank you.

@tombrazier
Copy link
Contributor

@thinkyhead it would be handy to have this merged so I can edit it.

thisiskeithb
thisiskeithb reviewed Apr 5, 2022
View reviewed changes
_gcode/M306.md Outdated Show resolved Hide resolved
@thisiskeithb
Copy link
Member

@tombrazier: You can add https://github.com/CRCinAU/MarlinDocumentation as a remote in the interim & send PRs to CRC's master branch & they will show up here once merged.

@tombrazier
Copy link
Contributor

@CRCinAU can you add a note to say M306 T will move the hotend to 1mm above the bed and so the hotend should be checked for blobs before running it. And that the 1mm can be configured with MPC_TUNING_POS.

@CRCinAU
Copy link
Contributor Author

CRCinAU commented Apr 5, 2022

@CRCinAU can you add a note to say M306 T will move the hotend to 1mm above the bed and so the hotend should be checked for blobs before running it. And that the 1mm can be configured with MPC_TUNING_POS.

Done.

@CRCinAU
Copy link
Contributor Author

CRCinAU commented Apr 30, 2022

@thinkyhead - Just wondering if this could be merged now?

@tombrazier tombrazier mentioned this pull request May 29, 2022
Merged
@thinkyhead thinkyhead merged commit f36c1e9 into MarlinFirmware:master Jun 4, 2022
thinkyhead pushed a commit that referenced this pull request Jun 4, 2022
@CRCinAU @thinkyhead
✨ M306: Model Predictive Control for hotends (#442)
ee647f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisiskeithb thisiskeithb thisiskeithb left review comments

Assignees
No one assigned
Labels
Section: G-code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CRCinAU @tombrazier @thisiskeithb @thinkyhead