Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Theme detection only detects dark mode #4

Closed
4 tasks done
MarmadileManteater opened this issue Jun 6, 2022 · 2 comments
Closed
4 tasks done

[Bug]: Theme detection only detects dark mode #4

MarmadileManteater opened this issue Jun 6, 2022 · 2 comments
Assignees
Labels
B: feature stopped working bug Something isn't working

Comments

@MarmadileManteater
Copy link
Owner

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.

Describe the bug

When opening the app, it fails to detect light mode correctly through the Cordova plugin.

Expected Behavior

The app should default to the system theme.

Issue Labels

feature stopped working

FreeTube Version

v0.16.0 66168e5

Operating System Version

Android 11, Kernel version 4.14.180-perf+ #1 Mon Mar 28 06:29:53 CDT 2022, Build number RPMS31.Q1-54-13.3-10

Installation Method (If applicable)

No response

Last Known Working FreeTube Version (If Any)

Theme detection never worked correctly in the android build. It used to automatically default to light mode.

Primary API used

Invidious API

Additional Information

I'm not sure if this is a bug in the Cordova plugin or if this is a bug in my code, but it is probably a bug in my code. I need to look into it.

Nightly Build

@MarmadileManteater MarmadileManteater added the bug Something isn't working label Jun 6, 2022
@MarmadileManteater MarmadileManteater self-assigned this Jun 6, 2022
MarmadileManteater added a commit that referenced this issue Jun 6, 2022
[Bug]: Theme detection only detects dark mode
@MarmadileManteater
Copy link
Owner Author

This issue is now resolved as of the above commit.

@MarmadileManteater
Copy link
Owner Author

MarmadileManteater commented Jun 6, 2022

The change should rollout in release: v0.16.0-nightly-11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: feature stopped working bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant