Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fast-Forward/Rewind Interval option is not being respected #442

Closed
5 tasks done
jinwk00 opened this issue Dec 1, 2024 · 6 comments
Closed
5 tasks done

[Bug]: Fast-Forward/Rewind Interval option is not being respected #442

jinwk00 opened this issue Dec 1, 2024 · 6 comments

Comments

@jinwk00
Copy link

jinwk00 commented Dec 1, 2024

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Set Fast-Forward/Rewind Interval to 5s in Player options
  2. Watch a video
  3. Double tap left or right to go forward or rewind
  4. Notice it always advances 10s

Expected Behavior

It should be going back and forth depending on option for Fast-forward/Rewind interval

Issue Labels

feature stopped working, usability issue

FreeTube Version

0.22.0.126

Operating System Version

Android 15, 5.15.170-android14-11-gf0d7580141e5 #1 Sun Nov 17 15:23:20 UTC 2024

Installation Method

.apk

Primary API used

Invidious API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

May be related to issue #56 , which implemented videojs-mobile-ui

Nightly Build

@absidue
Copy link

absidue commented Dec 6, 2024

This will be fixed by this upstream pull request: FreeTubeApp#6288

@jinwk00
Copy link
Author

jinwk00 commented Dec 7, 2024

Pull request merged

@jinwk00 jinwk00 closed this as completed Dec 7, 2024
@jinwk00
Copy link
Author

jinwk00 commented Dec 28, 2024

Seems that recently this regressed and is not working anymore, it's always -10/+10s

@jinwk00 jinwk00 reopened this Dec 28, 2024
@absidue
Copy link

absidue commented Dec 28, 2024

It definitely didn't regress you just never updated to a version that has the fix yet, because that version doesn't exist, as the change hasn't landed in a release yet (in upstream or in this repo).

I think you may have forgotten that you closed this when the pull request was merged (which was the correct thing to do, please close it again).

@jinwk00
Copy link
Author

jinwk00 commented Dec 28, 2024 via email

@absidue
Copy link

absidue commented Dec 28, 2024

Yes, it is only in the upstream nightlies (easy to tell if you look at the commits). It's always a massive amount of work and takes a long time to sync the repos because of all of the code conflicts and Android specific adjustments that have to be done every time, so it isn't done very often.

@jinwk00 jinwk00 closed this as completed Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants