Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Downloading videos does not work #6

Closed
4 tasks done
MarmadileManteater opened this issue Jun 6, 2022 · 1 comment
Closed
4 tasks done

[Bug]: Downloading videos does not work #6

MarmadileManteater opened this issue Jun 6, 2022 · 1 comment
Assignees
Labels
B: feature stopped working bug Something isn't working

Comments

@MarmadileManteater
Copy link
Owner

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.

Describe the bug

Downloading videos does not work in Cordova.

Expected Behavior

Clicking the download button should open a dialog box to select a location for the file. It should then download that file to the location and display a toast to the user when completed

Issue Labels

feature stopped working

FreeTube Version

v0.16.0 66168e5

Operating System Version

Android 11, Kernel version 4.14.180-perf+ #1 Mon Mar 28 06:29:53 CDT 2022, Build number RPMS31.Q1-54-13.3-10

Installation Method (If applicable)

No response

Last Known Working FreeTube Version (If Any)

This feature never worked in Cordova.

Primary API used

Invidious API

Additional Information

No response

Nightly Build

@MarmadileManteater MarmadileManteater added the bug Something isn't working label Jun 6, 2022
@MarmadileManteater MarmadileManteater self-assigned this Jun 6, 2022
MarmadileManteater added a commit that referenced this issue Aug 14, 2022
This doesn't download the videos through any
Cordova libraries or OS level operations, but it
will open the link in a web browser. With that
link, you can download the file through your
default web browser if you really are jones-in
 for that file. This fix is related to #6
MarmadileManteater added a commit that referenced this issue Aug 14, 2022
This doesn't download the videos through any
Cordova libraries or OS level operations, but it
will open the link in a web browser. With that
link, you can download the file through your
default web browser if you really are jones-in
 for that file. This fix is related to #6.
@MarmadileManteater
Copy link
Owner Author

This should be resolved as of commit bffbb42. This change should rollout in nightly release 48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: feature stopped working bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant