Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: SponsorBlock does not work #9

Closed
4 tasks done
MarmadileManteater opened this issue Jun 6, 2022 · 2 comments
Closed
4 tasks done

[Bug]: SponsorBlock does not work #9

MarmadileManteater opened this issue Jun 6, 2022 · 2 comments
Assignees
@MarmadileManteater
Labels
B: feature stopped working bug Something isn't working

Comments

@MarmadileManteater
Copy link
Owner

MarmadileManteater commented Jun 6, 2022 •
edited
Loading

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.

Describe the bug

After enabling SppnsorBlock, it doesn't seem to find any sponsored segments on any video. I haven't examined it further, but it is probably a CORS issue.

Expected Behavior

After enabling SponsorBlock, videos that have data in Sponsorblock should skip those segments automatically.

Issue Labels

feature stopped working

FreeTube Version

v0.16.0 66168e5

Operating System Version

Android 11, Kernel version 4.14.180-perf+ #1 Mon Mar 28 06:29:53 CDT 2022, Build number RPMS31.Q1-54-13.3-10

Installation Method (If applicable)

No response

Last Known Working FreeTube Version (If Any)

This feature never worked in Cordova.

Primary API used

Invidious API

Additional Information

No response

Nightly Build
@MarmadileManteater MarmadileManteater added the bug Something isn't working label Jun 6, 2022
@MarmadileManteater MarmadileManteater self-assigned this Jun 6, 2022
@MarmadileManteater MarmadileManteater changed the title [Bug]: SponsorBlock does not work. [Bug]: SponsorBlock does not work Jun 6, 2022
@MarmadileManteater
Copy link
Owner Author

As an update to this issue, after using the app daily for a while, I am finding that the skipping functionality of sponsor block works as intended, but skipped segments do not appear highlighted on the video timeline.

MarmadileManteater added a commit that referenced this issue Aug 17, 2022
@MarmadileManteater
This should eliminate this race condition by using
a151085 
the seconds length value provided by the API
rather than trying to pull the time from the video
element. This is related to FreeTubeApp#2492 and
#9.
PrestonN pushed a commit to FreeTubeApp/FreeTube that referenced this issue Aug 20, 2022
@MarmadileManteater
This should eliminate this race condition by using (#2493)
166fe00 
the seconds length value provided by the API
rather than trying to pull the time from the video
element. This is related to #2492 and
MarmadileManteater#9.
@MarmadileManteater
Copy link
Owner Author

This is now resolved by an upstream PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarmadileManteater MarmadileManteater

Labels
B: feature stopped working bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarmadileManteater