-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Getting Started Guide with note on port 5000 for MacOS #1994
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1994 +/- ##
=========================================
Coverage 78.23% 78.23%
Complexity 955 955
=========================================
Files 194 194
Lines 5293 5293
Branches 420 420
=========================================
Hits 4141 4141
Misses 706 706
Partials 446 446 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Per my comment in #1956 , there's not really a strong reason for us to map any of these ports to any specific host port. Only the web UI needs to be on a deterministic host port - the rest of the containers should probably rely on Docker to manage the port mapping behind the scenes |
@collado-mike, we could allow Docker to manage the port, but there are two use-cases for starting the API container. One being the web UI, but let's say you want to Who knew the macOS would have reserved port |
@RNHTTR Don't forget you have to sign your commit ;) More detail here: https://github.com/MarquezProject/marquez/pull/1994/checks?check_run_id=6479779860 |
Those are fair use cases - the former can be handled using the |
Signed-off-by: Ryan Hatter <ryan.hatter@astronomer.io>
Signed-off-by: Ryan Hatter <ryan.hatter@astronomer.io>
@collado-mike: In favor of making standing up Marquez locally on a Mac easier, and avoiding the port issue, we'll have docker assign the port (see #1956). We can merge for now, but make the port conflict changes to our docker compose files as follow up work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…zProject#1994) * Update Getting Started Guide with note on port 5000 for MacOS Signed-off-by: Ryan Hatter <ryan.hatter@astronomer.io> * Update README.md Signed-off-by: Ryan Hatter <ryan.hatter@astronomer.io> Co-authored-by: Willy Lulciuc <willy@datakin.com>
Problem
Port 5000 is now a reserved port on MacOS
Solution
Include note in getting started guide for how to run the API server on a custom port
Checklist
CHANGELOG.md
with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sql
database schema migration according to Flyway's naming convention (if relevant)Signed-off-by: Ryan Hatter ryannhatter@gmail.com