Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add linter to check for headers in Java files #2021

Closed
wants to merge 5 commits into from

Conversation

merobi-hub
Copy link
Collaborator

@merobi-hub merobi-hub commented Jun 23, 2022

Signed-off-by: Michael Robinson merobi@gmail.com

Problem

A linter as part of the Github Actions workflows could be used to automate the header checking process after the copyright/license PR is merged.

Note: this should be merged only after #1996 has been merged.

Solution

This PR adds the checkstyles linter to .github/workflows for the purpose of checking Java files for a header.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)

Signed-off-by: Michael Robinson <merobi@gmail.com>
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #2021 (c3b3cdf) into main (7a7a2a8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2021   +/-   ##
=========================================
  Coverage     78.89%   78.89%           
  Complexity     1014     1014           
=========================================
  Files           197      197           
  Lines          5548     5548           
  Branches        421      421           
=========================================
  Hits           4377     4377           
  Misses          724      724           
  Partials        447      447           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

…ncies

Signed-off-by: Michael Robinson <merobi@gmail.com>
Signed-off-by: Michael Robinson <merobi@gmail.com>
Signed-off-by: Michael Robinson <merobi@gmail.com>
@merobi-hub merobi-hub requested a review from wslulciuc June 29, 2022 20:12
@merobi-hub merobi-hub changed the title [DOCS] Add checkstyles linter to Github workflows for Java files [DOCS] Add linter to check for headers in Java files Jun 29, 2022
@merobi-hub merobi-hub closed this Sep 23, 2022
@wslulciuc wslulciuc deleted the header-linter-java branch November 7, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant