Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataset openapi model #2037

Closed
wants to merge 1 commit into from

Conversation

Esaych
Copy link
Contributor

@Esaych Esaych commented Jul 15, 2022

Problem

👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:

Closes: Bug Fix

Solution

Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a database schema migration, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change.

  • Dataset open-api type does not match Dataset model fully.
  • Needed to update tags to be arrays of strings rather than a single string.
  • Needed to add lastLifecycleState and deleted fields

Action item:

  • Marquez currently can (and does) return facets that do not have _producer and _schemaURL fields. I've decided to not update the type on this. @wslulciuc and I discussed we need to fix this in Marquez rather than the type def.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Sam Holmberg <sam.holmberg@astronomer.io>
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #2037 (b0b425d) into main (ba47e6e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2037   +/-   ##
=========================================
  Coverage     78.89%   78.89%           
  Complexity     1014     1014           
=========================================
  Files           197      197           
  Lines          5548     5548           
  Branches        421      421           
=========================================
  Hits           4377     4377           
  Misses          724      724           
  Partials        447      447           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Esaych
Copy link
Contributor Author

Esaych commented Jul 15, 2022

Cancelling in favor of signed branch: #2038

@Esaych Esaych closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants