Persist OpenLineage event before updating marquez model. #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunTransitionListener is invoked after updating the marquez model, but OpenLineage event is not available at that moment. This simply switch the order of it, that persists OpenLineage event first and then updates marquez model. With this change, OpenLineage event is already persisted and available from RunTransitionListener. Signed-off-by: Minkyu Park <minkyu.park.200@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Minkyu Park minkyu.park.200@gmail.com
Problem
When the RunTransitionListener is invoked, OpenLineage event is not persisted to the database. Because OpenLineage event is the source of truth of all marquez run transition, it would be nice to make it available from RunTransitionListener.
Solution
This PR simply switch the order of the code in order to persist the OpenLineage event first and then update the marquez model.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)