-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display current run state for job node in lineage graph #2146
Display current run state for job node in lineage graph #2146
Conversation
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Codecov Report
@@ Coverage Diff @@
## main #2146 +/- ##
=========================================
Coverage 75.78% 75.78%
Complexity 1061 1061
=========================================
Files 209 209
Lines 5006 5006
Branches 403 403
=========================================
Hits 3794 3794
Misses 763 763
Partials 449 449 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
warning: { | ||
main: '#7D7D7D' | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically, this would be an orange or yellow in a design system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referencing the colors defined in helpers/runs.ts
. Also, maybe I should just use runColorMap
defined in runs.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's go with that.
Thanks for working on UI @wslulciuc ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem
To view the current run state of a job, you have to select the job node in the lineage graph, then navigate the run info tab.
Solution
This PR fills job nodes in the lineage graph with the latest run state; this PR also makes some minor changes to column names used to display dataset and job metadata.
Checklist
CHANGELOG.md
with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sql
database schema migration according to Flyway's naming convention (if relevant)