Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display current run state for job node in lineage graph #2146

Merged

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Sep 27, 2022

Problem

To view the current run state of a job, you have to select the job node in the lineage graph, then navigate the run info tab.

Solution

This PR fills job nodes in the lineage graph with the latest run state; this PR also makes some minor changes to column names used to display dataset and job metadata.

Screen Shot 2022-09-28 at 3 44 45 PM

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg bot added the web label Sep 27, 2022
Signed-off-by: wslulciuc <willy@datakin.com>
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #2146 (3e46596) into main (b6544ec) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2146   +/-   ##
=========================================
  Coverage     75.78%   75.78%           
  Complexity     1061     1061           
=========================================
  Files           209      209           
  Lines          5006     5006           
  Branches        403      403           
=========================================
  Hits           3794     3794           
  Misses          763      763           
  Partials        449      449           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc requested a review from phixMe September 28, 2022 22:45
@wslulciuc wslulciuc added the review Ready for review label Sep 28, 2022
@wslulciuc wslulciuc marked this pull request as ready for review September 28, 2022 22:46
Comment on lines +35 to +37
warning: {
main: '#7D7D7D'
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, this would be an orange or yellow in a design system.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referencing the colors defined in helpers/runs.ts. Also, maybe I should just use runColorMap defined in runs.ts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's go with that.

@mobuchowski
Copy link
Contributor

Thanks for working on UI @wslulciuc ❤️

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phixMe phixMe merged commit 67e9249 into main Sep 30, 2022
@phixMe phixMe deleted the feature/display-current-run-state-for-job-in-lineage-graph branch September 30, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Ready for review web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants