Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Logo #2212

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Cloud Logo #2212

merged 5 commits into from
Nov 15, 2022

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Oct 25, 2022

Problem

We migrated the project to support Node 18 which included several webpack changes. Unfortunately, this broke the display of our main logo.

Solution

I referenced the cloud based url in GitHub to fetch the logo. This is a short term solution while we take a longer look at webpack and the asset loaders.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #2212 (a6699d3) into main (be52a06) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2212   +/-   ##
=========================================
  Coverage     76.72%   76.72%           
  Complexity     1147     1147           
=========================================
  Files           219      219           
  Lines          5318     5318           
  Branches        423      423           
=========================================
  Hits           4080     4080           
  Misses          763      763           
  Partials        475      475           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phixMe phixMe marked this pull request as ready for review October 26, 2022 20:10
@wslulciuc wslulciuc merged commit 3998e05 into main Nov 15, 2022
@wslulciuc wslulciuc deleted the quick-fix/marquez-url branch November 15, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants