Refactoring for display column lineage JSON #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>
Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>
…-column-lineage-of-dataset
Codecov Report
@@ Coverage Diff @@
## web/display-column-lineage-of-dataset #2301 +/- ##
========================================================================
Coverage 76.97% 76.97%
Complexity 1163 1163
========================================================================
Files 222 222
Lines 5298 5298
Branches 423 423
========================================================================
Hits 4078 4078
Misses 747 747
Partials 473 473 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tito12
changed the title
pawel-big-lebowski
merged commit 51fae37
into
MarquezProject:web/display-column-lineage-of-dataset
pawel-big-lebowski
pushed a commit
that referenced
this pull request
Dec 12, 2022
* refactoring for display column lineage JSON Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> * request api after click Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com>
tito12
added a commit
that referenced
this pull request
Dec 27, 2022
* display column lineage JSON Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com> * refactoring for display column lineage JSON (#2294) Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com> * Refactoring for display column lineage JSON (#2301) * refactoring for display column lineage JSON Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> * request api after click Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com> * call backend on tab switch Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com> * changes after review. refactoring. fix type and name of file Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Changes after review. Separate fetching data in child component Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * eslint fix changes Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com> Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com> Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> Co-authored-by: tito12 <vladyslav.sedenko@gmail.com> Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com> Co-authored-by: Pawel Leszczynski <pawelleszczynski@Pawels-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Loaded data could be heavy as request
Solution
Load after click on tab
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)