Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make name and type required for datasets in spec #2305

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Dec 9, 2022

Problem

When generating typescript from the openapi spec, the name and type for datasets are not required, but should be.

Solution

Mark name and type as required in the openapi spec for datasets.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg bot added the spec label Dec 9, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@90b2eff). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6c799fa differs from pull request most recent head 9757e54. Consider uploading reports for the commit 9757e54 to get more accurate results

@@           Coverage Diff           @@
##             main    #2305   +/-   ##
=======================================
  Coverage        ?   66.98%           
  Complexity      ?      227           
=======================================
  Files           ?       40           
  Lines           ?      945           
  Branches        ?      103           
=======================================
  Hits            ?      633           
  Misses          ?      162           
  Partials        ?      150           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc enabled auto-merge (squash) December 13, 2022 16:35
@wslulciuc wslulciuc merged commit f66007e into main Dec 13, 2022
@wslulciuc wslulciuc deleted the bug/spec-missing-required-fields-in-dataset branch December 13, 2022 16:41
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
Signed-off-by: wslulciuc <willy@datakin.com>

Signed-off-by: wslulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants