-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart fixes #2374
Helm chart fixes #2374
Conversation
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
Codecov Report
@@ Coverage Diff @@
## main #2374 +/- ##
=========================================
Coverage 76.81% 76.81%
Complexity 1195 1195
=========================================
Files 226 226
Lines 5473 5473
Branches 443 443
=========================================
Hits 4204 4204
Misses 772 772
Partials 497 497 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @perttus! 💯
@perttus, the changes look great! I've approved the PR, but looks like you'll need to sign your commits (please checkout our |
@perttus, need any guidance with the DCO check that's failing? Would be great to get this PR merged! |
Signed-off-by: Perttu Salonen <perttu.salonen@nitor.com>
Signed-off-by: Perttu Salonen <perttu.salonen@nitor.com>
190b454
to
d60b862
Compare
should be ok now |
Great job! Congrats on your first merged pull request in the Marquez project! |
Problem
Helm chart has some minor issues
Solution
Add postgres user for
pg_isready
and fix imagetag
Checklist
CHANGELOG.md
with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sql
database schema migration according to Flyway's naming convention (if relevant)