Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart fixes #2374

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Helm chart fixes #2374

merged 3 commits into from
Jan 26, 2023

Conversation

perttus
Copy link
Contributor

@perttus perttus commented Jan 20, 2023

Problem

Helm chart has some minor issues

Solution

Add postgres user for pg_isreadyand fix image tag

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the chart label Jan 20, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 20, 2023

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #2374 (190b454) into main (c7c89df) will not change coverage.
The diff coverage is n/a.

❗ Current head 190b454 differs from pull request most recent head 5f64b67. Consider uploading reports for the commit 5f64b67 to get more accurate results

@@            Coverage Diff            @@
##               main    #2374   +/-   ##
=========================================
  Coverage     76.81%   76.81%           
  Complexity     1195     1195           
=========================================
  Files           226      226           
  Lines          5473     5473           
  Branches        443      443           
=========================================
  Hits           4204     4204           
  Misses          772      772           
  Partials        497      497           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @perttus! 💯

@wslulciuc
Copy link
Member

wslulciuc commented Jan 23, 2023

@perttus, the changes look great! I've approved the PR, but looks like you'll need to sign your commits (please checkout our CONTRIBUTING.md for more details)

@wslulciuc
Copy link
Member

@perttus, need any guidance with the DCO check that's failing? Would be great to get this PR merged!

Signed-off-by: Perttu Salonen <perttu.salonen@nitor.com>
Signed-off-by: Perttu Salonen <perttu.salonen@nitor.com>
@perttus
Copy link
Contributor Author

perttus commented Jan 26, 2023

@perttus, need any guidance with the DCO check that's failing? Would be great to get this PR merged!

should be ok now

@wslulciuc wslulciuc enabled auto-merge (squash) January 26, 2023 17:53
@wslulciuc wslulciuc merged commit 74028c5 into MarquezProject:main Jan 26, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 26, 2023

Great job! Congrats on your first merged pull request in the Marquez project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants