Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed data for column lineage #2381

Merged
merged 7 commits into from
Jan 26, 2023

Conversation

rossturk
Copy link
Collaborator

@rossturk rossturk commented Jan 26, 2023

Problem

There is not currently any seed data for column-level lineage facets.

Closes: #2377

Solution

This adds some ColumnLineageDatasetFacet JSON snippets to docker/metadata.json in all the spots I thought were appropriate.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

rossturk and others added 4 commits January 25, 2023 20:44
Signed-off-by: Ross Turk <ross@rossturk.com>
Signed-off-by: Ross Turk <ross@rossturk.com>
Signed-off-by: Ross Turk <ross.turk@astronomer.io>
Signed-off-by: Ross Turk <ross@rossturk.com>
@boring-cyborg boring-cyborg bot added the docker label Jan 26, 2023
@rossturk rossturk changed the title Seed data for columnlineage Seed data for column lineage Jan 26, 2023
Signed-off-by: Ross Turk <ross@rossturk.com>
@boring-cyborg boring-cyborg bot added the docs label Jan 26, 2023
@rossturk rossturk requested a review from wslulciuc January 26, 2023 03:58
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@74028c5). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 87db304 differs from pull request most recent head eca174d. Consider uploading reports for the commit eca174d to get more accurate results

@@           Coverage Diff           @@
##             main    #2381   +/-   ##
=======================================
  Coverage        ?   76.81%           
  Complexity      ?     1195           
=======================================
  Files           ?      226           
  Lines           ?     5473           
  Branches        ?      443           
=======================================
  Hits            ?     4204           
  Misses          ?      772           
  Partials        ?      497           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

docker/down.sh Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rossturk!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@wslulciuc wslulciuc enabled auto-merge (squash) January 26, 2023 18:05
@wslulciuc wslulciuc merged commit 097c1a7 into MarquezProject:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add column-level lineage facets to seed data
2 participants