Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always render MqCode. #2454

Merged

Conversation

JDarDagran
Copy link
Contributor

@JDarDagran JDarDagran commented Mar 16, 2023

Problem

When no SqlJobFacet exists, Dataset and Job info pages fail to render.

Closes: #2453

Solution

Always render MqCode component and safely pass null if no sql property.

image

One-line summary:

Fix rendering Dataset and Job pages when no SqlJobFacet exists.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
@boring-cyborg boring-cyborg bot added the web label Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #2454 (cf62b2b) into main (c3163c0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2454   +/-   ##
=========================================
  Coverage     83.60%   83.60%           
  Complexity     1213     1213           
=========================================
  Files           231      231           
  Lines          5520     5520           
  Branches        266      266           
=========================================
  Hits           4615     4615           
  Misses          762      762           
  Partials        143      143           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@pawel-big-lebowski pawel-big-lebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Jakub 🚀 🥇 🔢 💯 👍

@pawel-big-lebowski pawel-big-lebowski merged commit 9fece97 into MarquezProject:main Mar 16, 2023
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When no SqlJobFacet exists, Dataset and Job info pages fail to render
2 participants