Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase namespace length to 1024 character #2554

Merged

Conversation

hloombaupgrade
Copy link
Contributor

@hloombaupgrade hloombaupgrade commented Jul 27, 2023

Problem

👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:

Python client for namespace length is still at 64 when Java Marquez client length changed to 1024 character. - marquez/common/models/NamespaceName.java

Closes: #ISSUE-NUMBER

Solution

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary: Changed namespace length constraint to sync up with Java client

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 27, 2023

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

Signed-off-by: Harsh Loomba <hloomba@upgrade.com>
@hloombaupgrade hloombaupgrade force-pushed the namespace-length-expansion branch from a4f6609 to 08588aa Compare July 27, 2023 20:17
Signed-off-by: Harsh Loomba <hloomba@upgrade.com>
Signed-off-by: Harsh Loomba <hloomba@upgrade.com>
Signed-off-by: Harsh Loomba <hloomba@upgrade.com>
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #2554 (c959fda) into main (50443ab) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2554   +/-   ##
=========================================
  Coverage     83.26%   83.26%           
  Complexity     1286     1286           
=========================================
  Files           243      243           
  Lines          5934     5934           
  Branches        279      279           
=========================================
  Hits           4941     4941           
  Misses          846      846           
  Partials        147      147           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hloombaupgrade! 💯

@wslulciuc wslulciuc merged commit e14cf9b into MarquezProject:main Jul 27, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 27, 2023

Great job! Congrats on your first merged pull request in the Marquez project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants