Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update i18n for general search filter and runInfo facets search #2557

Merged
merged 5 commits into from
Aug 4, 2023

Conversation

merobi-hub
Copy link
Collaborator

@merobi-hub merobi-hub commented Jul 31, 2023

Problem

Our i18n coverage/configuration does not cover the search filter dialog elements or the runInfo search placeholder.

Solution

This adds the component imports and variables, and updates the i18next config in the various languages we support currently.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary: updates i18n where needed in runInfo and search

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Michael Robinson <merobi@gmail.com>
Signed-off-by: Michael Robinson <merobi@gmail.com>
@boring-cyborg boring-cyborg bot added the web label Jul 31, 2023
@merobi-hub merobi-hub requested a review from phixMe July 31, 2023 19:02
@merobi-hub merobi-hub changed the title update I18n for general search filter and runInfo facets search update i18n for general search filter and runInfo facets search Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #2557 (22e90d7) into main (82d7279) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2557   +/-   ##
=========================================
  Coverage     83.26%   83.26%           
  Complexity     1286     1286           
=========================================
  Files           243      243           
  Lines          5934     5934           
  Branches        279      279           
=========================================
  Hits           4941     4941           
  Misses          846      846           
  Partials        147      147           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @merobi-hub

@merobi-hub merobi-hub merged commit 59f4552 into main Aug 4, 2023
@merobi-hub merobi-hub deleted the i18n/update branch August 4, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants