-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lineage events paging update #2577
Conversation
… to fix a number of bugs and code duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment, otherwise sweet UI upgrades 🔥🚀💯
Codecov Report
@@ Coverage Diff @@
## main #2577 +/- ##
=========================================
Coverage 83.26% 83.27%
Complexity 1286 1286
=========================================
Files 243 243
Lines 5934 5936 +2
Branches 279 279
=========================================
+ Hits 4941 4943 +2
Misses 846 846
Partials 147 147
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: phix <peter.hicks@astronomer.io>
Problem
Paging on the Lineage Events Page was pulling all the lineage events for all pages without using an offset.
Closes: #2455
Solution
We want to refresh our paging strategy and aesthetic overall to reflect a canonical set of mechanics as well, so this update includes some other assorted changes including
This change is inspired from some of the work in this ticket. #2455
Thanks https://github.com/ShreyasGit51283 for your work in thinking about how to better solve this problem.
One-line summary:
Refactor of the Lineage Events Page of our Application
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)