Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage events paging update #2577

Merged
merged 7 commits into from
Aug 10, 2023
Merged

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Aug 10, 2023

Problem

Paging on the Lineage Events Page was pulling all the lineage events for all pages without using an offset.

Closes: #2455

Solution

image

We want to refresh our paging strategy and aesthetic overall to reflect a canonical set of mechanics as well, so this update includes some other assorted changes including

  • Saved to and from dates in the url to send link and refresh the page
  • Paging
  • Loading indicators
  • Null vs Empty handling updates
  • Total events count
  • Font updates

This change is inspired from some of the work in this ticket. #2455

Thanks https://github.com/ShreyasGit51283 for your work in thinking about how to better solve this problem.

One-line summary:
Refactor of the Lineage Events Page of our Application

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added api API layer changes spec web labels Aug 10, 2023
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment, otherwise sweet UI upgrades 🔥🚀💯

api/src/main/java/marquez/api/OpenLineageResource.java Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #2577 (5779262) into main (a62fc04) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5779262 differs from pull request most recent head 779e2b1. Consider uploading reports for the commit 779e2b1 to get more accurate results

@@            Coverage Diff            @@
##               main    #2577   +/-   ##
=========================================
  Coverage     83.26%   83.27%           
  Complexity     1286     1286           
=========================================
  Files           243      243           
  Lines          5934     5936    +2     
  Branches        279      279           
=========================================
+ Hits           4941     4943    +2     
  Misses          846      846           
  Partials        147      147           
Files Changed Coverage Δ
api/src/main/java/marquez/db/OpenLineageDao.java 96.42% <ø> (ø)
...src/main/java/marquez/api/OpenLineageResource.java 90.62% <100.00%> (+0.62%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

phix added 3 commits August 10, 2023 10:05
@phixMe phixMe enabled auto-merge (squash) August 10, 2023 20:53
@phixMe phixMe merged commit 6bfc0d5 into main Aug 10, 2023
@phixMe phixMe deleted the feature/update-lineage-events-paging branch August 10, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes spec web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal - Improving UX of the Table pages
2 participants