Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Dont use hardcoed postgres image for initcontainer #2579

Merged

Conversation

terrpan
Copy link
Contributor

@terrpan terrpan commented Aug 11, 2023

Problem

The marquez deployment has a Postgresql wait-for-db init container with a hardcoded image. Due to this the global.imageRegistry value is not used for the "wait-for-db" init container. This creates problems for users that has to use private registries.

Closes: #ISSUE-NUMBER

Solution

I have added a template in chart/templates/helpers.tpl for the postgres image that returns the value from the postgres chart, or the global.imageRegistry input value . The template is then included in thechart/templates/marquez/deployment.yaml "wait-for-db" initContainer.

One-line summary:

Use the same postgresql image value for postgres and "wait-for-db" initcontainer.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: daniel.terry <daniel.terry@madepeople.se>
@boring-cyborg boring-cyborg bot added the chart label Aug 11, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 11, 2023

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #2579 (c8038a8) into main (0322365) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2579   +/-   ##
=========================================
  Coverage     83.28%   83.28%           
  Complexity     1287     1287           
=========================================
  Files           243      243           
  Lines          5936     5936           
  Branches        279      279           
=========================================
  Hits           4944     4944           
  Misses          845      845           
  Partials        147      147           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc enabled auto-merge (squash) August 12, 2023 17:48
@wslulciuc wslulciuc merged commit 94da246 into MarquezProject:main Aug 12, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 12, 2023

Great job! Congrats on your first merged pull request in the Marquez project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants