Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add node tooltip #2584

Closed

Conversation

davidsharp7
Copy link
Member

@davidsharp7 davidsharp7 commented Aug 12, 2023

Problem

Currently the Marquez UI compresses dataset/job name under each node if they are over x characters which leads to a sub optimal user experience when browsing nodes on a graph. The current tool tip just displays if the object is a job/dataset and so is not massively helpful.

Closes: #2580

Solution

Add an HTML tool tip which on hover over displays details about the node. Initially I would like to just update

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

sharpd added 2 commits August 12, 2023 11:53
Signed-off-by: sharpd <number6labs@gmail.com>
@boring-cyborg boring-cyborg bot added the web label Aug 12, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 12, 2023

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

@boring-cyborg boring-cyborg bot added the docs label Aug 12, 2023
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #2584 (20daaed) into main (0322365) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2584   +/-   ##
=========================================
  Coverage     83.28%   83.28%           
  Complexity     1287     1287           
=========================================
  Files           243      243           
  Lines          5936     5936           
  Branches        279      279           
=========================================
  Hits           4944     4944           
  Misses          845      845           
  Partials        147      147           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidsharp7 davidsharp7 deleted the feature/add-node-tooltip branch August 12, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add html tool tip for displaying node information
1 participant