ui:add HTML Tool Tip #2601
Merged
ui:add HTML Tool Tip #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sharpd <number6labs@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2601 +/- ##
=========================================
Coverage 83.30% 83.30%
Complexity 1287 1287
=========================================
Files 243 243
Lines 5935 5935
Branches 279 279
=========================================
Hits 4944 4944
Misses 844 844
Partials 147 147 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phixMe
reviewed
Aug 21, 2023
| @@ -43,26 +43,37 @@ const Node: React.FC<NodeProps> = ({ node, selectedNode, setSelectedNode }) => { | |||
| return '/' | |||
| } | |||
|
|
|||
| const addToToolTip = (inputData: GraphNode<MqNode>) => { | |||
| // return react fragment | |||
There was a problem hiding this comment.
I don't think you need a comment here.
phixMe
reviewed
Aug 21, 2023
| >{children}</Tooltip> | ||
| } | ||
|
|
||
| export default MQTooltip |
There was a problem hiding this comment.
I think this needs a newline to pass our linting setup.
phixMe
reviewed
Aug 21, 2023
| children : ReactElement | ||
| } | ||
|
|
||
| //default style thing |
Signed-off-by: sharpd <number6labs@gmail.com>
phixMe
approved these changes
Aug 21, 2023
|
Great job! Congrats on your first merged pull request in the Marquez project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the Marquez UI compresses dataset/job name under each node if they are over x characters which leads to a sub optimal user experience when browsing nodes on a graph. The current tool tip just displays if the object is a job/dataset and so is not massively helpful.
Closes: #2580
Solution
One-line summary:
Add Tool tip to display basic node details.
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)