-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add available column level tags #2606
add available column level tags #2606
Conversation
Signed-off-by: sharpd <number6labs@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2606 +/- ##
=========================================
Coverage 83.30% 83.30%
Complexity 1287 1287
=========================================
Files 243 243
Lines 5935 5935
Branches 279 279
=========================================
Hits 4944 4944
Misses 844 844
Partials 147 147 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 💯 🥇
const formatColumnTags = (tags: string[]) => { | ||
const theme = createTheme(useTheme()) | ||
return <>{tags.map((tag, index) => ( | ||
<span |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the span here. I think we can just use the chip itself with marginRight applied to that component itself.
For applying marginRIght
I would say something like:
marginRight: index < tags.length - 1 ? theme.spacing(1) : 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool - away racing this weekend but will fix it up Monday (NZ time)
Signed-off-by: sharpd <number6labs@gmail.com>
Signed-off-by: sharpd <number6labs@gmail.com>
Problem
Currently any dataset columns with tags are not displayed in the dataset information pane. The data is available in the field.tags var.
Closes: #2605
Solution
add a new column called "tags" to the dataset column view and add the tags associated with the dataset column.
One-line summary:
add a new column called "tags" to the dataset column view and add the tags associated with the dataset column.
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)