Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add available column level tags #2606

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

davidsharp7
Copy link
Member

@davidsharp7 davidsharp7 commented Aug 30, 2023

Problem

Currently any dataset columns with tags are not displayed in the dataset information pane. The data is available in the field.tags var.

Closes: #2605

Solution

add a new column called "tags" to the dataset column view and add the tags associated with the dataset column.

Screenshot 2023-09-06 at 05 53 39

One-line summary:

add a new column called "tags" to the dataset column view and add the tags associated with the dataset column.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: sharpd <number6labs@gmail.com>
@boring-cyborg boring-cyborg bot added the web label Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #2606 (ce197d0) into main (e85127c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2606   +/-   ##
=========================================
  Coverage     83.30%   83.30%           
  Complexity     1287     1287           
=========================================
  Files           243      243           
  Lines          5935     5935           
  Branches        279      279           
=========================================
  Hits           4944     4944           
  Misses          844      844           
  Partials        147      147           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 💯 🥇

const formatColumnTags = (tags: string[]) => {
const theme = createTheme(useTheme())
return <>{tags.map((tag, index) => (
<span
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the span here. I think we can just use the chip itself with marginRight applied to that component itself.

For applying marginRIght I would say something like:
marginRight: index < tags.length - 1 ? theme.spacing(1) : 0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - away racing this weekend but will fix it up Monday (NZ time)

sharpd added 2 commits September 4, 2023 15:44
Signed-off-by: sharpd <number6labs@gmail.com>
Signed-off-by: sharpd <number6labs@gmail.com>
@phixMe phixMe merged commit 8d954d6 into MarquezProject:main Sep 5, 2023
@davidsharp7 davidsharp7 deleted the web/add_tags_to_dataset branch December 31, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web: Column Level Tags are not displayed in the UI
3 participants