Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop table job_contexts and usage #2621

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Drop table job_contexts and usage #2621

merged 2 commits into from
Sep 26, 2023

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Sep 23, 2023

This PR removes the usage of job_contexts (replaced by OL facets) and adds a migration to drop the table. This PR is also a follow up to #2373.

Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg bot added the api API layer changes label Sep 23, 2023
@wslulciuc wslulciuc self-assigned this Sep 23, 2023
@wslulciuc wslulciuc added db and removed api API layer changes labels Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #2621 (0e6073b) into main (45b7281) will not change coverage.
The diff coverage is n/a.

❗ Current head 0e6073b differs from pull request most recent head 2578e67. Consider uploading reports for the commit 2578e67 to get more accurate results

@@            Coverage Diff            @@
##               main    #2621   +/-   ##
=========================================
  Coverage     83.33%   83.33%           
  Complexity     1291     1291           
=========================================
  Files           244      244           
  Lines          5940     5940           
  Branches        279      279           
=========================================
  Hits           4950     4950           
  Misses          844      844           
  Partials        146      146           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc added the review Ready for review label Sep 23, 2023
@boring-cyborg boring-cyborg bot added the api API layer changes label Sep 26, 2023
@wslulciuc wslulciuc enabled auto-merge (squash) September 26, 2023 14:58
@wslulciuc wslulciuc merged commit 2c573dc into main Sep 26, 2023
2 checks passed
@wslulciuc wslulciuc deleted the feature/drop-job-context branch September 26, 2023 15:06
@wslulciuc wslulciuc mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes db review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants