Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of current_job_context_uuid column #2622

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Sep 23, 2023

This PR removes the usage of job_context_uuid (and current_job_context_uuid). We will follow up with a PR to drop the column scheduled to be release in 0.43.0.

Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc added the db label Sep 23, 2023
@boring-cyborg boring-cyborg bot added the api API layer changes label Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #2622 (6d237bb) into main (2c573dc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2622   +/-   ##
=========================================
  Coverage     83.33%   83.33%           
  Complexity     1291     1291           
=========================================
  Files           244      244           
  Lines          5940     5940           
  Branches        279      279           
=========================================
  Hits           4950     4950           
  Misses          844      844           
  Partials        146      146           
Files Coverage Δ
api/src/main/java/marquez/db/JobDao.java 100.00% <ø> (ø)
api/src/main/java/marquez/db/RunDao.java 92.40% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc removed the api API layer changes label Sep 23, 2023
Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg bot added the api API layer changes label Sep 23, 2023
@wslulciuc wslulciuc added review Ready for review and removed api API layer changes labels Sep 23, 2023
@wslulciuc wslulciuc marked this pull request as ready for review September 23, 2023 08:04
@wslulciuc wslulciuc self-assigned this Sep 23, 2023
@boring-cyborg boring-cyborg bot added the api API layer changes label Sep 26, 2023
@wslulciuc wslulciuc merged commit 301487e into main Sep 26, 2023
3 checks passed
@wslulciuc wslulciuc deleted the feature/remove-usage-of-current_job_context_uuid-col branch September 26, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes db review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants