Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hover over tool tip to dataset tags #2630

Merged

Conversation

davidsharp7
Copy link
Member

@davidsharp7 davidsharp7 commented Oct 1, 2023

Problem

Dataset level tags dont have the hover over tool tip that column level tags have.

Closes: #2631

Solution

Add hover over tool tip to dataset level tags to bring into line with column level tags.

Screenshot 2023-10-01 at 18 43 39

One-line summary:
Add tag hover over tag descriptions to dataset level tags.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: sharpd <number6labs@gmail.com>
@boring-cyborg boring-cyborg bot added the web label Oct 1, 2023
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #2630 (b865068) into main (75da43c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2630   +/-   ##
=========================================
  Coverage     83.35%   83.35%           
  Complexity     1295     1295           
=========================================
  Files           244      244           
  Lines          5948     5948           
  Branches        279      279           
=========================================
  Hits           4958     4958           
  Misses          844      844           
  Partials        146      146           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: sharpd <number6labs@gmail.com>
@davidsharp7 davidsharp7 marked this pull request as ready for review October 2, 2023 05:46
@wslulciuc wslulciuc requested a review from phixMe October 3, 2023 16:02
@wslulciuc wslulciuc added the review Ready for review label Oct 3, 2023
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit b865068
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6524cde292cbc60008151e9f

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidsharp7

@phixMe phixMe merged commit fd4d1c3 into MarquezProject:main Oct 10, 2023
6 checks passed
@davidsharp7 davidsharp7 deleted the web/add_tag_hover_to_dataset_info branch December 31, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Ready for review web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tag description hover over to Dataset Tags
3 participants