Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end point to delete field level tags. #2705

Conversation

davidsharp7
Copy link
Member

@davidsharp7 davidsharp7 commented Dec 17, 2023

Problem

Currently we can add tags at a dataset field level but cannot delete them.

Closes: #2703

Solution

Add DELETE end point for dataset field tags and remove data references from

dataset_fields_tag_mapping
dataset_versions

One-line summary:

Add delete end point to remove dataset field tags.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: sharpd <number6labs@gmail.com>
@boring-cyborg boring-cyborg bot added api API layer changes client/java labels Dec 17, 2023
Copy link

netlify bot commented Dec 17, 2023

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit c7556b3
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6583e198ab1c410008a176e5

Signed-off-by: sharpd <number6labs@gmail.com>
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba1cb33) 84.34% compared to head (c7556b3) 84.42%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2705      +/-   ##
============================================
+ Coverage     84.34%   84.42%   +0.07%     
- Complexity     1414     1416       +2     
============================================
  Files           251      251              
  Lines          6402     6434      +32     
  Branches        291      291              
============================================
+ Hits           5400     5432      +32     
  Misses          850      850              
  Partials        152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidsharp7 davidsharp7 changed the title Adding a resource to Add end point to delete field level tags. Dec 17, 2023
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A much needed API 💯 💯 💯

@wslulciuc wslulciuc merged commit f3c3057 into MarquezProject:main Dec 30, 2023
16 checks passed
@wslulciuc wslulciuc added this to the 0.44.0 milestone Dec 30, 2023
@davidsharp7 davidsharp7 deleted the feature/add-delete-end-point-for-column-tags branch December 31, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes client/java
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Add DELETE end point to allow for deletion of field level tags
2 participants