-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end point to delete field level tags. #2705
Merged
wslulciuc
merged 5 commits into
MarquezProject:main
from
davidsharp7:feature/add-delete-end-point-for-column-tags
Dec 30, 2023
Merged
Add end point to delete field level tags. #2705
wslulciuc
merged 5 commits into
MarquezProject:main
from
davidsharp7:feature/add-delete-end-point-for-column-tags
Dec 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sharpd <number6labs@gmail.com>
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Signed-off-by: sharpd <number6labs@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2705 +/- ##
============================================
+ Coverage 84.34% 84.42% +0.07%
- Complexity 1414 1416 +2
============================================
Files 251 251
Lines 6402 6434 +32
Branches 291 291
============================================
+ Hits 5400 5432 +32
Misses 850 850
Partials 152 152 ☔ View full report in Codecov by Sentry. |
davidsharp7
changed the title
Adding a resource to
Add end point to delete field level tags.
Dec 17, 2023
wslulciuc
approved these changes
Dec 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A much needed API 💯 💯 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently we can add tags at a dataset field level but cannot delete them.
Closes: #2703
Solution
Add DELETE end point for dataset field tags and remove data references from
One-line summary:
Add delete end point to remove dataset field tags.
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)