Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life updates for new lineage graph #2750

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Feb 19, 2024

Problem

image

Several small updates for our graph:

  • Preserve complete and full mode in the url for lineage graph navigation
  • Default complete mode to false (This is going to make large graphs more palatable)
  • Adding button to zoom to the selected node. (Lineage graph only)

One-line summary: Visual updates from early feedback on lineage graph navigation.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Feb 19, 2024
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 7adaeb3
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/65d3a8f3b4e3bd000835d8a0

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32ae5cb) 84.45% compared to head (7adaeb3) 84.45%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2750   +/-   ##
=========================================
  Coverage     84.45%   84.45%           
  Complexity     1416     1416           
=========================================
  Files           251      251           
  Lines          6447     6447           
  Branches        291      291           
=========================================
  Hits           5445     5445           
  Misses          850      850           
  Partials        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc merged commit a9b0b3e into main Feb 21, 2024
16 checks passed
@wslulciuc wslulciuc deleted the update/web-lineage-display branch February 21, 2024 01:27
yanlibert pushed a commit to libertyann/marquez that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants