-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add facets to openapi marquez spec #894
Add facets to openapi marquez spec #894
Conversation
Signed-off-by: henneberger <git@danielhenneberger.com>
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
============================================
- Coverage 75.01% 74.30% -0.72%
+ Complexity 730 500 -230
============================================
Files 152 117 -35
Lines 3118 2370 -748
Branches 308 234 -74
============================================
- Hits 2339 1761 -578
+ Misses 369 304 -65
+ Partials 410 305 -105 Continue to review full report at Codecov.
|
@henneberger : Should we also add facets to the source and namespace models? I think it'd make sense to have the core models of marquez contain the facet field for extensibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. I like that we live all facets be generic in this spec. Marquez treats all facets the same whether they are standard or custom.
I would advise against adding facets to source and namespace in that spec.
In openlineage, the namespace is just a mechanism to make unique name, the metadata is around jobs, datasets and runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excited to begin adding support for facets to the marquez model 💯
This proposal adds open lineage facets to the marquez API for jobs, datasets, and runs. Additionally, this deprecates the context parameter and convert contexts to a special context facet. This will allow cross compatibility between the existing marquez apis and open lineage.
See: #895
Signed-off-by: henneberger git@danielhenneberger.com