Skip to content

Commit

Permalink
Delete deprecated record models called "Main" instead of "Record" (#323)
Browse files Browse the repository at this point in the history
  • Loading branch information
MarshalX authored May 9, 2024
1 parent 1688eba commit dc5f92b
Show file tree
Hide file tree
Showing 15 changed files with 1 addition and 227 deletions.
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/actor/profile.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,6 @@ class Record(base.RecordModelBase):
py_type: t.Literal['app.bsky.actor.profile'] = Field(default='app.bsky.actor.profile', alias='$type', frozen=True)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyActorProfile.Record`."""

Expand Down
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/feed/generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,6 @@ class Record(base.RecordModelBase):
py_type: t.Literal['app.bsky.feed.generator'] = Field(default='app.bsky.feed.generator', alias='$type', frozen=True)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyFeedGenerator.Record`."""

Expand Down
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/feed/like.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,6 @@ class Record(base.RecordModelBase):
py_type: t.Literal['app.bsky.feed.like'] = Field(default='app.bsky.feed.like', alias='$type', frozen=True)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyFeedLike.Record`."""

Expand Down
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/feed/post.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,20 +85,6 @@ class Record(base.RecordModelBase):
py_type: t.Literal['app.bsky.feed.post'] = Field(default='app.bsky.feed.post', alias='$type', frozen=True)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyFeedPost.Record`."""

Expand Down
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/feed/repost.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,6 @@ class Record(base.RecordModelBase):
py_type: t.Literal['app.bsky.feed.repost'] = Field(default='app.bsky.feed.repost', alias='$type', frozen=True)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyFeedRepost.Record`."""

Expand Down
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/feed/threadgate.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,20 +64,6 @@ class Record(base.RecordModelBase):
)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyFeedThreadgate.Record`."""

Expand Down
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/graph/block.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,6 @@ class Record(base.RecordModelBase):
py_type: t.Literal['app.bsky.graph.block'] = Field(default='app.bsky.graph.block', alias='$type', frozen=True)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyGraphBlock.Record`."""

Expand Down
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/graph/follow.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,6 @@ class Record(base.RecordModelBase):
py_type: t.Literal['app.bsky.graph.follow'] = Field(default='app.bsky.graph.follow', alias='$type', frozen=True)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyGraphFollow.Record`."""

Expand Down
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/graph/list.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,6 @@ class Record(base.RecordModelBase):
py_type: t.Literal['app.bsky.graph.list'] = Field(default='app.bsky.graph.list', alias='$type', frozen=True)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyGraphList.Record`."""

Expand Down
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/graph/listblock.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,6 @@ class Record(base.RecordModelBase):
)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyGraphListblock.Record`."""

Expand Down
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/graph/listitem.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,6 @@ class Record(base.RecordModelBase):
py_type: t.Literal['app.bsky.graph.listitem'] = Field(default='app.bsky.graph.listitem', alias='$type', frozen=True)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyGraphListitem.Record`."""

Expand Down
14 changes: 0 additions & 14 deletions packages/atproto_client/models/app/bsky/labeler/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,20 +29,6 @@ class Record(base.RecordModelBase):
)


class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)

def __init__(self, **data: t.Any) -> None:
import warnings

warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)


class GetRecordResponse(base.SugarResponseModelBase):
"""Get record response for :obj:`models.AppBskyLabelerService.Record`."""

Expand Down
6 changes: 1 addition & 5 deletions packages/atproto_client/models/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,13 +166,9 @@ def is_record_type(model: t.Union[ModelBase, DotDict], expected_type: t.Union[st
"""
if isinstance(expected_type, types.ModuleType):
# for now, all records are defined in the Record class
# TODO(MarshalX): remove backward compatibility for Main
if not hasattr(expected_type, 'Main') or not hasattr(expected_type, 'Record'):
if not hasattr(expected_type, 'Record'):
return False

if hasattr(expected_type, 'Main'):
expected_type = expected_type.Main.model_fields['py_type'].default

if hasattr(expected_type, 'Record'):
expected_type = expected_type.Record.model_fields['py_type'].default

Expand Down
18 changes: 0 additions & 18 deletions packages/atproto_codegen/models/generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -509,20 +509,6 @@ def _generate_response_model(nsid: NSID, output_body: models.LexXrpcBody) -> str
return _generate_xrpc_body_model(nsid, output_body, ModelType.RESPONSE)


_MAIN_MODEL_BACKWARD_COMPATIBILITY = """
class Main(Record):
def __init_subclass__(cls, **data: t.Any) -> None:
import warnings
warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init_subclass__(**data)
def __init__(self, **data: t.Any) -> None:
import warnings
warnings.warn('Main class is deprecated. Use Record class instead.', DeprecationWarning, stacklevel=2)
super().__init__(**data)
"""


def _generate_def_model(nsid: NSID, def_name: str, def_model: models.LexObject, model_type: ModelType) -> str:
lines = [
_get_model_class_def(def_name, model_type),
Expand All @@ -537,10 +523,6 @@ def _generate_def_model(nsid: NSID, def_name: str, def_model: models.LexObject,
lines.append(f"{_(1)}py_type: t.Literal['{def_type}'] = Field(default='{def_type}', alias='$type', frozen=True)")
lines.append('')

# TODO(MarshalX): remove it
if model_type is ModelType.RECORD:
lines.append(_MAIN_MODEL_BACKWARD_COMPATIBILITY)

return join_code(lines)


Expand Down
36 changes: 0 additions & 36 deletions tests/test_atproto_client/models/test_backward_compatibility.py

This file was deleted.

0 comments on commit dc5f92b

Please sign in to comment.