Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the dynamic version in pyproject.toml #53

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

fxcoudert
Copy link
Contributor

Fixes #52

@MarshalX
Copy link
Owner

Thank you! Should we use

dynamic = ["version"]

instead?

I really do not want to specify the same version and many places

@fxcoudert
Copy link
Contributor Author

Yes, that also fixes the issue. PR amended. A new point release would be welcome, to fix the build in conda-forge: conda-forge/libipld-feedstock#3

@fxcoudert
Copy link
Contributor Author

Hi @MarshalX could this be merged?

@MarshalX
Copy link
Owner

MarshalX commented Jan 3, 2025

Hi @fxcoudert sorry I am vacating right now. I need to test it locally first. I ll back in week or two

@fxcoudert
Copy link
Contributor Author

kind ping on this

@MarshalX MarshalX changed the title Specify version in pyproject.toml Specify the dynamic version in pyproject.toml Feb 17, 2025
Copy link

codspeed-hq bot commented Feb 17, 2025

CodSpeed Performance Report

Merging #53 will not alter performance

Comparing fxcoudert:version (22ab9f4) with main (744bc2f)

Summary

✅ 192 untouched benchmarks

@MarshalX MarshalX merged commit dd0917a into MarshalX:main Feb 17, 2025
3 checks passed
@MarshalX
Copy link
Owner

I am very sorry for the long delay; i had a second vacation; i will release a new version hopefully today; gonna update deps first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version is not specified in pyproject.toml
2 participants