Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Сделал поле uri класса Description опциональным #661

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

Ninnjah
Copy link
Contributor

@Ninnjah Ninnjah commented Oct 30, 2024

Столкнулся с проблемой, что некоторые исполнители не имеют данного поля из-за чего происходит ошибка
`TypeError: Description.init() missing 1 required positional argument: 'uri'

@MarshalX
Copy link
Owner

Спасибо. Стоит обновить ещё тест тогда тут:

def test_de_json_required(self, client):
json_dict = {'text': self.text, 'uri': self.uri}
description = Description.de_json(json_dict, client)
assert description.text == self.text
assert description.uri == self.uri

@MarshalX MarshalX merged commit 2a09dcb into MarshalX:main Oct 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants