Hostname handling fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 3, 2022 19:27
For HTTP this is defined to be 80 and 443, so it acts the same way as the host/:authority header. Signed-off-by: Matt Turner <user.personal@users.noreply.github.com>
Signed-off-by: Matt Turner <user.personal@users.noreply.github.com>
mt-inside
force-pushed
the
mt-hostname-fixes
branch
from
e552983 to
38f4333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, the MS docs say the SPN should contain a port number if the port is non-standard; introduce this behaviour.
Secondly, if the Host header has been overridden, use that for the SPN as that's almost certainly the service's idea of its own name (rather than the host in the URL, which is what will be dialled).