Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp fix for notes #4

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Temp fix for notes #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/mkslides.default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ slides:
highlight_theme: monokai
reveal.js:
history: true # Necessary for back/forward buttons and livereload
slideNumber: "c/t"
9 changes: 7 additions & 2 deletions assets/templates/index.html.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,18 @@

<ul>
{%+ for s in slideshows %}
<li><a href="{{ s.location }}" target="_blank">{{ s.title }}</a> (<a href="{{ s.location }}?print-pdf" target="_blank">PDF version</a>)</li>
<li>
{{ s.title }}:
<a href="{{ s.location }}" target="_blank" title="View slides">slides</a>
<!-- / <a href="{{ s.location }}?view=scroll" target="_blank">scroll</a> -->
/ <a href="{{ s.location }}?print-pdf&showNotes=separate-page" target="_blank" title="Download as PDF with speaker notes for printing">PDF</a>
</li>
{% endfor %}
</ul>

<p>
Slides last build at <code>{{ build_datetime.strftime('%Y-%m-%d %H:%M:%S') }}</code>.<br />
The PDF version link generates a single-page document suitable for <a href="https://revealjs.com/pdf-export/" target="_blank">saving as a PDF for printing</a>.
The PDF link generates a single-page document (including speaker notes) suitable for <a href="https://revealjs.com/pdf-export/" target="_blank">saving as a PDF for printing</a>.
</p>
</body>
</html>
7 changes: 2 additions & 5 deletions assets/templates/slideshow.html.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,7 @@
<script src="{{ revealjs_path }}/plugin/markdown/markdown.js"></script>
<script src="{{ revealjs_path }}/plugin/highlight/highlight.js"></script>
<script src="{{ revealjs_path }}/plugin/zoom/zoom.js"></script>
<!--
https://github.com/hakimel/reveal.js/issues/3659
<script src="{{ revealjs_path }}/plugin/notes/notes.js"></script>
-->
<script src="{{ revealjs_path }}/plugin/notes/notes.js"></script>
<script src="{{ revealjs_path }}/plugin/math/math.js"></script>

{% if plugins %}
Expand All @@ -60,7 +57,7 @@
RevealMarkdown,
RevealHighlight,
RevealZoom,
// RevealNotes, // https://github.com/hakimel/reveal.js/issues/3659
RevealNotes,
RevealMath,

{% if plugins %}
Expand Down
66 changes: 35 additions & 31 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ include = [{ path = "assets", format = ["sdist", "wheel"] }]
[tool.poetry.dependencies]
python = "^3.12"
Jinja2 = "^3.1.4"
livereload = "^2.7.0"
python-frontmatter = "^1.1.0"
PyYAML = "^6.0.2"
rich = "^13.8.0"
Expand All @@ -21,6 +20,9 @@ jsonschema = "^4.23.0"
natsort = "^8.4.0"
emoji = "^2.12.1"

# TODO: go back to official package, see https://github.com/MartenBE/mkslides-reveal/issues/3
livereload = { git = "https://github.com/Lucas-C/python-livereload.git", branch = "issue-277" }

[tool.poetry.group.dev.dependencies]
bumpver = "^2023.1129"
mypy = "^1.11.2"
Expand Down