Handle non-UTF-8 endpoint_name by changing Protobuf field from string to bytes #243
Conversation
Modify endpoint_name from string to bytes
"endpoint_name: Some(sys_metrics::host::get_hostname()?.into()), consumes the newly formatted String and returns a Vec<u8>
|
Thanks for looking at this! I just wonder if the same needs to be done elsewhere (like files names, etc...). For example: |
|
I definitely had that thought, but stopped shortly after getting it working generally last night. I just tried playing around with an mp3 file which has embedded Title, Artist, Album, Genre, Year, Track # and Disc # metadata in addition to the usual info like Date Created and Date Modified. I additionally compiled my branch of rquickshare for MacOS and ran it there, alongside my existing Android/Windows/Linux setup. For every combination on my device/platform matrix (both send and receive) I was not able to get the data or metadata of my mp3 to fail in any way, suggesting to me it's not an issue. Notably I don't have duplicate devices on-hand to test MacOS <-> MacOS, Linux <-> Linux, etc but I have no reason to believe it'd be broken in those specific transfers. If you have any specific files or cases you'd like me to test, please let me know and I'd be happy to do so! |
|
Perfect, if you tested it as you're explaining, that's enough for me :) Lets merge this PR, and I'll make a release soon after some more tests on my side! |
Changing "endpoint_name" from string to bytes allows "endpoint_name" to carry non-UTF-8 encoded data. I haven't confirmed, but I suspect Windows is something like Windows-1252 encoding. Adding ".into())" wraps the string into a Vec so it gets correctly serialized as bytes to match the changed protobuf definition. This tentatively fixes the other half of #141 .
I haven't tested Linux -> Linux or Linux <-> MacOS compatibility under this new format, but I can confirm that I am now able to successfully send and receive files back and forth between Linux, Android, and Windows freely with the usual/expected behaviors.