Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #13

Merged
merged 5 commits into from
Sep 20, 2020
Merged

Tests #13

merged 5 commits into from
Sep 20, 2020

Conversation

MartinHeroux
Copy link
Owner

Add tests and minor fixed/edits

@MartinHeroux MartinHeroux merged commit a62d1a4 into master Sep 20, 2020
bbelderbos
bbelderbos reviewed Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@bbelderbos bbelderbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - awesome you added quite some test code here!

tests/test_parser.py Show resolved Hide resolved
tests/test_parser.py Show resolved Hide resolved
tests/test_figure_diff.py
matplotlib.use("Qt5Agg")


@pytest.mark.mpl_image_compare(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using plugin, cool! could you use parametrize here even?

tests/test_diff_axis_creator.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbelderbos bbelderbos bbelderbos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinHeroux @bbelderbos