MVP working #4
Merged
MVP working #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbelderbos
reviewed
Sep 11, 2020
| fontsize: int = 9 | ||
|
|
||
| def __repr__(self): | ||
| return f'PliffyInfoABD(\n' \ |
There was a problem hiding this comment.
nice discovery of __repr__
| @@ -92,7 +92,7 @@ def test_paired_diff_mean_and_confidence_interval(pliffy_data_paired_short): | |||
|
|
|||
|
|
|||
| def test_paired_diffs(pliffy_data_paired_short): | |||
| actual = estimate._paired_diffs(pliffy_data_paired_short) | |||
| actual = estimate._calc_paired_diffs(pliffy_data_paired_short) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am pretty happy with the current state of the package.
I have some documentation and typehints to add, and also a bunch of tests. But I revised lots and added lots and the
pliffyworks as expected for a both paired (e.g. participants rated fatigue after running vs biking) and unpaired data (e.g. control group vs intervention group).I have included a
demo.pyfile that currently is for you and me to test that things work. You can change stuff likepaired vs unpaired, colors, whether raw data is shown as points or lines for paired data, etc. I will expand this to have it run aspliffy.demo()so that new users can confirm it works on their system, and it can show off show of the options that are available.