chore: adds menu item class for issue adobe#202

Martskin · Oct 14, 2019 · ef0d6f4 · ef0d6f4
1 parent ae0b3e6
commit ef0d6f4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/components/menu/index.css b/components/menu/index.css
@@ -99,7 +99,7 @@ governing permissions and limitations under the License.
     }
   }
 
-  .spectrum-Icon {
+  .spectrum-Menu-itemIcon {
     /* Don't get smaller, you're an icon! */
     flex-shrink: 0;
     align-self: flex-start;

diff --git a/components/menu/metadata/menu.yml b/components/menu/metadata/menu.yml
@@ -47,13 +47,13 @@ examples:
             <span class="spectrum-Menu-sectionHeading" id="menu-heading-category-2"  aria-hidden="true">Section Heading</span>
             <ul class="spectrum-Menu" role="group" aria-labelledby="menu-heading-category-1" aria-disabled="true">
               <li class="spectrum-Menu-item" role="menuitem" tabindex="0">
-                <svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="SaveFloppy">
+                <svg class="spectrum-Icon spectrum-Icon--sizeS spectrum-Menu-itemIcon" focusable="false" aria-hidden="true" aria-label="SaveFloppy">
                   <use xlink:href="#spectrum-icon-18-SaveFloppy"></use>
                 </svg>
                 <span class="spectrum-Menu-itemLabel">Save</span>
               </li>
               <li class="spectrum-Menu-item is-disabled" role="menuitem" aria-disabled="true">
-                <svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="DataDownload">
+                <svg class="spectrum-Icon spectrum-Icon--sizeS spectrum-Menu-itemIcon" focusable="false" aria-hidden="true" aria-label="DataDownload">
                   <use xlink:href="#spectrum-icon-18-DataDownload"></use>
                 </svg>
                 <span class="spectrum-Menu-itemLabel">Download</span>
@@ -89,7 +89,7 @@ examples:
               </li>
               <li class="spectrum-Menu-item is-selected" role="option" tabindex="0">
                 <span class="spectrum-Menu-itemLabel">My best friend's mom's house in the burbs just off Silverado street</span>
-                <svg class="spectrum-Icon spectrum-UIIcon-CheckmarkMedium spectrum-Menu-checkmark" focusable="false" aria-hidden="true">
+                <svg class="spectrum-Icon spectrum-UIIcon-CheckmarkMedium spectrum-Menu-checkmark spectrum-Menu-itemIcon" focusable="false" aria-hidden="true">
                   <use xlink:href="#spectrum-css-icon-CheckmarkMedium" />
                 </svg>
               </li>
@@ -112,7 +112,7 @@ examples:
           </li>
           <li class="spectrum-Menu-item is-open" role="menuitem" tabindex="0">
             <span class="spectrum-Menu-itemLabel">Feather...</span>
-            <svg class="spectrum-Icon spectrum-UIIcon-ChevronRightMedium spectrum-Menu-chevron" focusable="false" aria-hidden="true" aria-label="Next">
+            <svg class="spectrum-Icon spectrum-UIIcon-ChevronRightMedium spectrum-Menu-chevron spectrum-Menu-itemIcon" focusable="false" aria-hidden="true" aria-label="Next">
               <use xlink:href="#spectrum-css-icon-ChevronRightMedium" />
             </svg>
           </li>