Coherence rule changes in latest nightly break parser-combinators

[hugoduncan]

The impls for Stream for &str and &[T] now conflict with that for I: Iterator + Clone.

This is due to the changes in rust-lang/rust#23867, in particular the negative reasoning as demonstrated in the Replacer example.

The problem in this case, iiuc, is that &str and &[T] could one day decide to implement Iterator.

[hawkw]

👍

[Marwes]

That's an annoying breaking change. Guess the Iterator impl needs to be wrapped in a newtype though it is quite an unergonomic workaround. Still, it feels better than to remove the &str and &[T] impls since parsing a string directly is so common.

[Marwes]

Fixed in c3c54a8 and pushed to cargo with 6398c2e (0.2.6).

I am not sure that these changes are the ideal choice though, might be that the Stream trait is better of being only implemented for Iterator, essentially making it an Iterator with a Clone bound