Fix erase sector failure on S25FL127S

[hanyazou]

I found that all erase command except chip erase failed on my MKR1000 and Cypress S25FL127S (128Mbits). TestFlash.ino did not show any errors but flash.eraseSector(), eraseBlock32K() and eraseBlock64K() did not take effect.

I used my logic analyzer and noticed that the library send out some garbage on SPI bus after erase command and 3 address bytes. I added missing break statements in SPIFlash::_beginSPI() because that lacks some essential break statement in switch/case. (commit 1: 1de2c10)

Then I found that the library did not wait until the busy bit in SR1 was cleared. Timeout argument of _notBusy() must be in micro-second. 500L means 500 micro seconds which is too short to wait for completion of erase command. I've add " * 1000" to the arguments. (commit 2: 9633c2f)

And I modified TestFlash.ino to check error of erase commands execution. (commit 3: a179306)

I've tested these changes on my MKR1000 and S25FL127S and they looks working correctly. (S25FL127S does not have Erase Block 32 command however.)

[Marzogh]

Thanks for catching and fixing that. 😄 I'll just double check that it has't broken anything else and will roll it into a bug fix release within the next fortnight.

[Marzogh]

Gah! I have no idea how this even happened! Thank you for catching the missing break;

[Marzogh]

Thanks! Your changes make it easier to work with. I'll sort out the background code to throw an UNSUPPORTEDFUNC error when eraseBlock32 is called with the S25FL127S