textDocument/rename may return duplicates

[Yanpas]

No matter which mention of a variable I rename I get this warning. Here is formatted strace RPC output:

{
  "jsonrpc": "2.0",
  "id": 391,
  "result": {
    "documentChanges": [
      {
        "textDocument": {
          "uri": "file:///home/yan/dev/blabla.cpp",
          "version": 0
        },
        "edits": [
          {
            "range": {
              "start": { "line": 69, "character": 19 },
              "end": { "line": 69, "character": 25 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 70, "character": 71 },
              "end": { "line": 70, "character": 77 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 75, "character": 10 },
              "end": { "line": 75, "character": 16 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 75, "character": 10 },
              "end": { "line": 75, "character": 16 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 78, "character": 10 },
              "end": { "line": 78, "character": 16 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 79, "character": 79 },
              "end": { "line": 79, "character": 85 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 67, "character": 16 },
              "end": { "line": 67, "character": 22 }
            },
            "newText": "db_path"
          }
        ]
      }
    ]
  }
}

The duplicate is on line 75. The thing is that line 75 has macro (LOGINFO), so deduplicating should be performed by language server

[MaskRay]

Mostly fixed by #296

Actually Index{Func,Type,Var}::uses are not guaranteed to be ordered so last_position as used in #294 does not address all duplicates.

The textDocument/rename handler had another bug:

// textDocument/rename on `f`
void f();
void g() { m(); } // incorrectly rewrote m() before

#296 fixes the case when WorkingFile *wf is available (textDocument/didOpen has been sent for the document). If wf is nullptr, ideally the handler should load the contents in the filesystem, but that is rare and may have other issues so I didn't address that in #296.

[Yanpas]

If wf is nullptr, ideally the handler should load the contents in the filesystem

Does it mean that if I rename some function which is mentioned in 3 files and I have opened only 1 file, then those 2 files won't be touched and will remain invalid?

[MaskRay]

@Yanpas If wf is nullptr (because the file isn't opened), the file will still be touched. It is just that the "identifier literally occurs" check isn't enabled (because ccls doesn't know the file contents). In rare occasions textDocument/rename may corrupt the file.