Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static member variable informations aren't correctly forwarded to the Language client #593

Closed
FederAndInk opened this issue Mar 19, 2020 · 0 comments

Comments

@FederAndInk
Copy link
Contributor

FederAndInk commented Mar 19, 2020

Observed behavior

The SymbolKind of static member variable is SymbolKind::Variable and not SymbolKind::Field.

I don't know if it is expected.

The point is that It is then difficult to know on the client if we have a member or not.

I thought about checking if the parentKind was a SymbolKind::Class, but then I saw this information was not forwarded to the client, and received a SymbolKind::Unknown(0). (see MaskRay/vscode-ccls#90)

Expected behavior

Either mark static member variable kind as SymbolKind::Field
or forward the parentKind information (I have tested it if you want to see and tell me if this could work or if there is another cleaner way to do this: FederAndInk@b6491f5)

System information

  • ccls version (git describe --tags --long):
ccls version 0.20190823.5-18-g5a08ff99
clang version 9.0.1 
FederAndInk added a commit to FederAndInk/ccls that referenced this issue Apr 5, 2020
otherwise this is impossible to distinguish a static variable from a
static member variable
Close (MaskRay#593)
MaskRay pushed a commit to FederAndInk/ccls that referenced this issue Apr 22, 2020
otherwise this is impossible to distinguish a static variable from a
static member variable
Close (MaskRay#593)
MaskRay pushed a commit to FederAndInk/ccls that referenced this issue Apr 22, 2020
otherwise this is impossible to distinguish a static variable from a
static member variable
Close MaskRay#593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant