Fix completion result sorting in VSCode #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaskRay
force-pushed
the
master
branch
6 times, most recently
from
e4927d2 to
da360d2
Compare
Riatre
force-pushed
the
fix-fixit-completion-sort
branch
from
3ea45f7 to
719c398
Compare
MaskRay
pushed a commit
that referenced
this pull request
Jan 30, 2019
MaskRay
pushed a commit
that referenced
this pull request
Mar 18, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 24, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 25, 2019
MaskRay
pushed a commit
that referenced
this pull request
Oct 25, 2019
MaskRay
pushed a commit
that referenced
this pull request
Nov 10, 2019
MaskRay
pushed a commit
that referenced
this pull request
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207. Not tested on other clients.
Explain of root cause: #207 (comment).
This patch is trying to align the
textEdit.rangein all results and adjust theirfilterTextaccordingly, so they always have same range and prefix.Feel free to amend, this is more complicated than what I thought it would be...