Fix document symbol with a range based method (outline and breadcumbs) #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FederAndInk
commented
Jul 20, 2020
| std::unordered_map<SymbolIdx, std::unique_ptr<DocumentSymbol>> sym2ds; | ||
| std::vector<std::pair<std::vector<const void *>, DocumentSymbol *>> funcs, | ||
| types; | ||
| std::vector<ExtentRef> syms; |
There was a problem hiding this comment.
We may want this to be a vector of pointer to take less memory 32B to 8B per element and then sort the pointers.
FederAndInk
changed the title
|
Is there someone who can review this? |
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
ee29996 to
feb153a
Compare
FederAndInk
force-pushed
the
fix/document_symbol_range_based
branch
from
4d979af to
ca7252c
Compare
FederAndInk
force-pushed
the
fix/document_symbol_range_based
branch
from
ca7252c to
407f78e
Compare
eg: int i, j, k; outline before: k j i after: i j k
|
i can say this fixed the issue for me, so I'm in favor! |
MaskRay
pushed a commit
that referenced
this pull request
May 9, 2021
MaskRay
pushed a commit
that referenced
this pull request
May 9, 2021
MaskRay
pushed a commit
that referenced
this pull request
May 9, 2021
MaskRay
pushed a commit
that referenced
this pull request
May 9, 2021
MaskRay
reviewed
May 9, 2021
MaskRay
reviewed
May 9, 2021
MaskRay
pushed a commit
that referenced
this pull request
May 9, 2021
MaskRay
pushed a commit
that referenced
this pull request
May 9, 2021
MaskRay
pushed a commit
that referenced
this pull request
May 9, 2021
out-of-line class members (#674)
MaskRay
pushed a commit
that referenced
this pull request
May 9, 2021
out-of-line class members (#674)
MaskRay
reviewed
May 9, 2021
MaskRay
pushed a commit
that referenced
this pull request
May 9, 2021
out-of-line class members (#674)
MaskRay
pushed a commit
that referenced
this pull request
May 9, 2021
out-of-line class members (#674)
MaskRay
reviewed
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #660, I have redone all the algorithm for hierarchical document symbol, it is based on ranges of symbols and not on symbols and their children because some of them were missing and "duplicates" were removed (eg: namespace redefinition in the same file, or inline function defined after the class)
When we have members defined outside the class in a namespace in a separate file, the namespace doesn't have the members as children. The outline and breadcrumbs don't work correctly for them.
Before:
After:
There are other bugs with outline that I noticed which I am working on: