Support zAxisAuto settings from GroundControl (B12 Y) #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about moving the pin definition up to the top where the AUX pins are defined, so it's clear which pins have been committed? AUX4 is the z-axis depth probe presently. When moving the definition out of the function, maybe name spindleControlPin would be better? |
|
@blurfl AUX1 has already been committed, and I just made the existing code configurable. AUX1 has 2 different usages depending on the configuration (servo signal vs 5v). I'll clean this up a bit. |
clean up Pin defines
|
It looks good. Thanks for cleaning up the AUX4 definition as well. Ship it! |
blurfl
added a commit
to blurfl/Firmware
that referenced
this pull request
Feb 16, 2018
PR MaslowCNC#328 added a setting to enable/disable spindle control. The setting was named 'zAxisAuto' which seems confusing as it is being used as an on/off control for spindle power. Change the name and accompanying text in Report.cpp to 'spindleAutomation' to better reflect its use. Note that the change in GC that accomanied MaslowCNC#328 was PR MaslowCNC#458.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firmware update that allows setting the AUX1 to to be active high for supporting M codes based on
B12 Y